-
Notifications
You must be signed in to change notification settings - Fork 323
feat: add splunkhec receiver #3440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kalleep
wants to merge
39
commits into
main
Choose a base branch
from
kalleep/feat-otel-splunkhecreceiver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+741
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💻 Deploy preview available: |
docs/sources/reference/components/otelcol/otelcol.receiver.influxdb.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.influxdb.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.splunkhec.md
Outdated
Show resolved
Hide resolved
There's a few other doc-related comments not yet applied. Do we need to discuss the suggestions? Or are they pending a commit? |
@clayton-cornell no they are fine, just missed them and have been busy getting fixing the ci |
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…luxdb.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…luxdb.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
…unkhec.md Co-authored-by: Clayton Cornell <[email protected]>
45e3488
to
8d3048c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pr adds
otelcol.receiver.splunkhec
component. This is a wrapper for https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/splunkhecreceiver.Currently this support all settings from upstream except
ack
. To support this we must also add support forAckExtention
. We can wait with that until we see a need for it.I did some manual testing that it works
Request to generate log:
curl http://localhost:8088/ -d '{"time": 1437522387, "source": "my_source", "sourcetype": "my_sample_data", "index": "my_index", "host": "my_host", "event": { "message": "some message", "severity": "Info" }}'
Request to generate metric:
curl http://localhost:8088/ -d '{"time": 1437522387, "source": "my_source", "sourcetype": "my_sample_data", "index": "my_index", "host": "my_host", "event": "metric", "fields": {"metric_name:single": 123 }]'
Which issue(s) this PR fixes
Fixes: #3080
Notes to the Reviewer
We had a lot of functions in different tests named
getFreeAddr
that did the same thing. I added this function tocomponenttests
and reused it in every place I could find.PR Checklist