Skip to content

Update config options for windows_exporter process collector #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaco-vanzyl
Copy link

PR Description

The process.iis argument can now be passed to the process collector to enable IIS process name queries.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

The `process.iis` argument can now be passed to the process collector to enable IIS process name queries.
@jaco-vanzyl jaco-vanzyl requested review from clayton-cornell and a team as code owners April 23, 2025 09:54
@CLAassistant
Copy link

CLAassistant commented Apr 23, 2025

CLA assistant check
All committers have signed the CLA.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Apr 23, 2025
@jaco-vanzyl
Copy link
Author

Hi @clayton-cornell I am unsure why the linux build failed as it is unrelated to the changes I am introducing to the Alloy agent. Would this failure require a new issue to be opened or will you be able to assist with clearing the blocker? I have also signed the CLA and I am not entirely sure why it wouldn't update on the PR.

@dehaansa
Copy link
Collaborator

Hi @clayton-cornell I am unsure why the linux build failed as it is unrelated to the changes I am introducing to the Alloy agent. Would this failure require a new issue to be opened or will you be able to assist with clearing the blocker? I have also signed the CLA and I am not entirely sure why it wouldn't update on the PR.

  1. I've restarted the tests, to see if it's a flaky test. If not, I'll be sure to make a separate issue to track it.
  2. The CLA was recently reset, if you haven't signed it in the past few weeks it will require re-signing, sorry!

@jaco-vanzyl
Copy link
Author

jaco-vanzyl commented Apr 24, 2025

Hi @clayton-cornell I am unsure why the linux build failed as it is unrelated to the changes I am introducing to the Alloy agent. Would this failure require a new issue to be opened or will you be able to assist with clearing the blocker? I have also signed the CLA and I am not entirely sure why it wouldn't update on the PR.

  1. I've restarted the tests, to see if it's a flaky test. If not, I'll be sure to make a separate issue to track it.
  2. The CLA was recently reset, if you haven't signed it in the past few weeks it will require re-signing, sorry!

Thanks for looking into the test failure.

CLA was definitely signed. I think only a maintainer might be able to rerun the CLA check.
You have agreed to the CLA for grafana/alloy
Version: 2021-04-20

@dehaansa
Copy link
Collaborator

CLA was definitely signed. I think only a maintainer might be able to rerun the CLA check. You have agreed to the CLA for grafana/alloy Version: 2021-04-20

It appears the commit is associated with a different github user (@\jaco-van-zyl-derivco) than the PR (@\jaco-vanzyl). Perhaps you committed with a different email than the account you've signed in to the github UI with?

@jaco-vanzyl
Copy link
Author

CLA was definitely signed. I think only a maintainer might be able to rerun the CLA check. You have agreed to the CLA for grafana/alloy Version: 2021-04-20

It appears the commit is associated with a different github user (@\jaco-van-zyl-derivco) than the PR (@\jaco-vanzyl). Perhaps you committed with a different email than the account you've signed in to the github UI with?

Thanks for the spot, seems I got my creds mixed up when I committed, all signed and ready to go :)

@jaco-vanzyl
Copy link
Author

@clayton-cornell could you please assist with a final check?

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs

@clayton-cornell
Copy link
Contributor

@dehaansa Over to you or the team for technical review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants