-
Notifications
You must be signed in to change notification settings - Fork 323
Update config options for windows_exporter process collector #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The `process.iis` argument can now be passed to the process collector to enable IIS process name queries.
Hi @clayton-cornell I am unsure why the linux build failed as it is unrelated to the changes I am introducing to the Alloy agent. Would this failure require a new issue to be opened or will you be able to assist with clearing the blocker? I have also signed the CLA and I am not entirely sure why it wouldn't update on the PR. |
|
Thanks for looking into the test failure. CLA was definitely signed. I think only a maintainer might be able to rerun the CLA check. |
It appears the commit is associated with a different github user (@\jaco-van-zyl-derivco) than the PR (@\jaco-vanzyl). Perhaps you committed with a different email than the account you've signed in to the github UI with? |
Thanks for the spot, seems I got my creds mixed up when I committed, all signed and ready to go :) |
@clayton-cornell could you please assist with a final check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for docs
@dehaansa Over to you or the team for technical review. |
PR Description
The
process.iis
argument can now be passed to the process collector to enable IIS process name queries.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist