[otelcol.connector.servicegraph] Remove seconds from metric names #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
clayton-cornell
added
type/docs
clayton-cornell
approved these changes
Feb 18, 2025
|
@clayton-cornell the upstream change was introduced in v0.109:
Alloy v1.4 was still running v0.108, which didn't have this change. Alloy v1.5 and v1.6 have been using more recent versions of otel. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
) (cherry picked from commit ea62263)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
) (cherry picked from commit ea62263)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change upstream to remove the
_secondssuffix.. OTel has a "unit" property which says the unit (seconds in this case).