Skip to content

Remove progress animation on streaming #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Remove progress animation on streaming #6709

merged 5 commits into from
Dec 13, 2023

Conversation

aliabid94
Copy link
Collaborator

Fixes: #1494

Also improves UI when streaming from webcam. To test:

import gradio as gr

def iden(img):
    return img

with gr.Blocks() as demo:
    with gr.Row():
        input_img = gr.Image(sources=["webcam"])
        output_img = gr.Image()
        input_img.stream(lambda x:x, input_img, output_img)

if __name__ == "__main__":
    demo.launch(show_api=False) 
import gradio as gr

def iden(img):
    return img

with gr.Blocks() as demo:
    with gr.Row():
        input_img = gr.Audio(sources=["microphone"])
        output_img = gr.Audio()
        input_img.stream(lambda x:x, input_img, output_img)

if __name__ == "__main__":
    demo.launch(show_api=False) 

@aliabid94 aliabid94 requested review from hannahblair and freddyaboulton and removed request for hannahblair December 8, 2023 15:12
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 8, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/c7ded7b1a1f2a2f97289e8dc70cd159010709db8/gradio-4.8.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c7ded7b1a1f2a2f97289e8dc70cd159010709db8#subdirectory=client/python"

@aliabid94 aliabid94 requested a review from abidlabs December 8, 2023 15:13
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 8, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/image patch
@gradio/upload patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Remove progress animation on streaming

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair
Copy link
Collaborator

Tested and LGTM!

@abidlabs
Copy link
Member

abidlabs commented Dec 8, 2023

@nateraw will be happy we finally got around to this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove loading indicator when using gr.Image streaming mode
6 participants