-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Improve CSS token documentation in Storybook #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/19c5c408c7de4add1e46385ab492eb1eac4e7dd8/gradio-4.8.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@19c5c408c7de4add1e46385ab492eb1eac4e7dd8#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@hannahblair can you explain the addition of the A few things I was unsure about:
![]()
![]() |
Ah the trusty groot file is broken now! I've replaced the broken link with an image from our AWS bucket in the Row story and a couple others. I also meant to remove the Shadows story and the TokenRow component; they're not needed now as we'll take a more user friendly approach to documenting these css vars. |
Description
This PR adds a few more stories with the css variables we use. It also removes hardcoded widths and heights for any icons and moves that sizing to their respective component. This improves the icons story a bit more.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh