Skip to content

Svelte migration (WIP) #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 58 commits into from
Jan 27, 2022
Merged

Svelte migration (WIP) #448

merged 58 commits into from
Jan 27, 2022

Conversation

aliabid94
Copy link
Collaborator

Migrating React to Svelte.

@height
Copy link

height bot commented Jan 5, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@aliabid94
Copy link
Collaborator Author

  • New frontend currently stored in "frontend-svelte".
  • Subset of components implemented so far, can test with running "demo/calculator/run.py" to start backend and then running "npm run dev" from frontend/svelte-migration to launch svelte frontend.

@abidlabs abidlabs marked this pull request as draft January 5, 2022 05:33
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look over this it looks good to me. I do have some questions about how we're handling the getting/setting of values, out approach to loading components, the tooling we're using here (rollup, et al), and I also have a few accessibility concerns but I don't think this is the right place for those discussions/ changes.

We should try to get this in ASAP and keep it scoped tightly to just the svelte migration and we can have those other discussions and make any improvements in future, smaller, pull requests.

{...input_component}
{theme}
value={input_values[i]}
setValue={setValues.bind(this, i)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be more idiomatic as setValue={value => setValues(i, value)}

@aliabid94 aliabid94 marked this pull request as ready for review January 27, 2022 02:33
@aliabid94 aliabid94 merged commit d6b1247 into master Jan 27, 2022
@aliabid94 aliabid94 deleted the svelte-migration branch January 27, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants