Skip to content

Migrate from useWorkletCallback #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025

Conversation

tomekzaw
Copy link
Contributor

@tomekzaw tomekzaw commented Jul 8, 2025

Please provide enough information so that others can review your pull request:

Motivation

This PR converts all usages of useWorkletCallback which is deprecated and will be removed in Reanimated 4 to useCallback with 'worklet'; directive.

@Yurii-Lutsyk
Copy link

Sorry, are u going to merge this pr or there are any blockers?

@lucaswitch
Copy link

I didn't see this pr coming but i tried a slight different approach on #2374 keeping it backwards compatible with v3.

@Yurii-Lutsyk
Copy link

#2374

Yes, your approach is even better

@gorhom
Copy link
Owner

gorhom commented Jul 27, 2025

thanks @tomekzaw for submitting this PR 🙌

@gorhom gorhom merged commit 5c8096c into gorhom:master Jul 27, 2025
@gorhom
Copy link
Owner

gorhom commented Jul 27, 2025

it should be released with v5.1.7

@Yurii-Lutsyk
Copy link

thanks @tomekzaw for submitting this PR 🙌

I really appreciate your work. Huge shoutouts to you

@hsyndeniz
Copy link

Tried the release with Reanimated v4. Both BottomSheet and BottomSheetModal are affected. BottomSheet appears instantly without any animation, even with animationConfigs. BottomSheetModal doesn’t appear at all.

@leecuong666
Copy link

Tried the release with Reanimated v4. Both BottomSheet and BottomSheetModal are affected. BottomSheet appears instantly without any animation, even with animationConfigs. BottomSheetModal doesn’t appear at all.

I even call .present() and can't open the modal

@lyonscrawl
Copy link

i noticed also the issue with Reanimated 4, for now i moved to @lodev09/react-native-true-sheet and have no issue.

gorhom added a commit that referenced this pull request Jul 27, 2025
* fix(#2356): added missing dependencies to callback hooks

* Update BottomSheet.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants