-
-
Notifications
You must be signed in to change notification settings - Fork 867
Migrate from useWorkletCallback
#2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, are u going to merge this pr or there are any blockers? |
I didn't see this pr coming but i tried a slight different approach on #2374 keeping it backwards compatible with v3. |
Yes, your approach is even better |
thanks @tomekzaw for submitting this PR 🙌 |
it should be released with |
I really appreciate your work. Huge shoutouts to you |
Tried the release with Reanimated v4. Both BottomSheet and BottomSheetModal are affected. BottomSheet appears instantly without any animation, even with animationConfigs. BottomSheetModal doesn’t appear at all. |
I even call .present() and can't open the modal |
i noticed also the issue with Reanimated 4, for now i moved to @lodev09/react-native-true-sheet and have no issue. |
Please provide enough information so that others can review your pull request:
Motivation
This PR converts all usages of
useWorkletCallback
which is deprecated and will be removed in Reanimated 4 touseCallback
with'worklet';
directive.