Skip to content

selectively enable large media elements #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yossizahn opened this issue Jan 24, 2017 · 4 comments
Closed

selectively enable large media elements #2334

yossizahn opened this issue Jan 24, 2017 · 4 comments

Comments

@yossizahn
Copy link

Describe the issue

cannot selectively enable large media elements

One or more specific URLs where the issue occurs

all sites with more than 1 large-media-element according to configured settings. e.g. (taken from wiki page for per-site switches) http://www.tomshardware.com/reviews/samsung-gear-vr-headset,4405.html

Steps for anyone to reproduce the issue

  1. set "block media elements larger than 50kb"
  2. enable logger
  3. navigate to http://www.tomshardware.com/reviews/samsung-gear-vr-headset,4405.html
  4. logger shows multiple large-media-elements blocked
  5. hover mouse over a blocked picture - it will show a magnifying glass
  6. click on blocked picture - reload will be attempted
  7. logger shows that the reload was blocked due to "no-large-media: * true"
  8. temporarily enable large-media-elements - all blocked pictures display

summary:
there is no way to selectively enable large-media-elements and there is no apparent function for the magnifying glass on hover over blocked picture - unless for some reason the blocked element is constantly changing size.

Your settings

globally block media elements larger than 50kb

  • Browser/version: chrome 55.0.2883.87 m (64-bit)
  • uBlock Origin version: 1.10.4
@yossizahn
Copy link
Author

yossizahn commented Jan 30, 2017 •
edited
Loading

Update: I didn't mention before that I am normally on a very slow connection, and via a proxy. Today when using a fast connection and no proxy I had no problems at all and clicking on a large media element immediately enabled it. So I don't know if it's the connection speed or the proxy causing things not to work.

@gorhill gorhill mentioned this issue Oct 30, 2017
Closed
@Atavic Atavic mentioned this issue Dec 27, 2017
Closed
gorhill added a commit that referenced this issue Oct 18, 2020
@gorhill
Improve interactivity for blocked large media elements
53dd339 
Related issues:
- #1390
- #2334

The deadline to interactively load a specific media
element has been extended from 2sec to 5sec.

Clicking over a blocked large media element will cause
uBO to lookup and handle all potentially blocked large
elements at the cursor position. This should take care
of being able to unblock media elements hidden under
other DOM object.

The CSS style applied to blocked large media elements
has been fine tuned to improve interactivity.

uBO will now remember the specific media elements which
were unblocked and keep them exempted from being
further blocked. This would be an issue when unblocking
a video and then a bit later seeking to another point
in the video, in which case uBO would again block
network requests for that video.
@ghost
Copy link

ghost commented Oct 19, 2020

Emulating "Slow 3g" in dev tools, Network tab in Chrome Version 86.0.4240.75 (Official Build) (64-bit). Link from OP, 50kB limit.

Click to load does not allow image to load in 1.30.4.

Loading works as expected in 1.30.5b6. There is a small delay before dotted border is painted - can be page loading images with delay (lazyload)?

@gorhill
Copy link
Owner

gorhill commented Oct 19, 2020 •
edited
Loading

can be page loading images with delay (lazyload)?

The content script used for interactivity/styling is injected with document_idle, so it could be just the browser taking its time to inject the content script.

@gorhill
Copy link
Owner

gorhill commented Dec 6, 2020

Closing as fixed with recent changes to the related code. A new issue should be opened if new cases are identified.

@gorhill gorhill closed this as completed Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorhill @yossizahn