Remove unnecessary code of dirsnapshot.py

[QuantumEnergyE]

if isinstance(entry, str) is used to distinguish listdir from scandir. Now scandir is used by default, we can delete this code.

[QuantumEnergyE]

@BoboTiG PTAL

[BoboTiG]

Thanks @QuantumEnergyE !

[chadgates]

@QuantumEnergyE @BoboTiG : now having following error and believe this removal may be the root for it - in version 2.2.1:

Traceback (most recent call last): File "/usr/local/lib/python3.10/threading.py", line 1016, in _bootstrap_inner self.run() File "/usr/local/lib/python3.10/site-packages/sentry_sdk/integrations/threading.py", line 69, in run reraise(*_capture_exception()) File "/usr/local/lib/python3.10/site-packages/sentry_sdk/_compat.py", line 59, in reraise raise value File "/usr/local/lib/python3.10/site-packages/sentry_sdk/integrations/threading.py", line 67, in run return old_run_func(self, *a, **kw) File "/usr/local/lib/python3.10/site-packages/watchdog/observers/api.py", line 148, in run self.queue_events(self.timeout) File "/usr/local/lib/python3.10/site-packages/watchdog/observers/polling.py", line 91, in queue_events new_snapshot = self._take_snapshot() File "/usr/local/lib/python3.10/site-packages/watchdog/observers/polling.py", line 72, in <lambda> self._take_snapshot = lambda: DirectorySnapshot( File "/usr/local/lib/python3.10/site-packages/watchdog/utils/dirsnapshot.py", line 251, in __init__ for p, st in self.walk(path): File "/usr/local/lib/python3.10/site-packages/watchdog/utils/dirsnapshot.py", line 258, in walk paths = [os.path.join(root, entry.name) for entry in self.listdir(root)] File "/usr/local/lib/python3.10/site-packages/watchdog/utils/dirsnapshot.py", line 258, in <listcomp> paths = [os.path.join(root, entry.name) for entry in self.listdir(root)] AttributeError: 'str' object has no attribute 'name'

[BoboTiG]

@chadgates what function do you pass to the listdir argument when instantiating DirectorySnapshot?

[chadgates]

@BoboTiG : PollingObserverVFS(stat=os.stat, listdir=os.listdir), should I not do that ?

[BoboTiG]

As those arguments are/were the defaults values, not need to set them. Simply remove all of them:

PollingObserverVFS()

[chadgates]

When I changed code to:
new_observer = PollingObserverVFS()
I get error:
TypeError: PollingObserverVFS.init() missing 2 required positional arguments: 'stat' and 'listdir'

[BoboTiG]

My bad, I didn't check the class itself:

PollingObserverVFS(os.stat, os.scandir)

I don't why those are positional arguments 🤔

[chadgates]

That did the job! Thanks.