Skip to content

[ENHANCEMENT] Add support for autocompletion with flags in REPL mode #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

[ENHANCEMENT] Add support for autocompletion with flags in REPL mode #3057

merged 2 commits into from
Feb 26, 2025

Conversation

GLobyNew
Copy link
Contributor

Implemented autocompletion with flags in REPL mode for issue #3017

@GLobyNew
Copy link
Contributor Author

GLobyNew commented Feb 25, 2025 •
edited
Loading

Okay, fixing lint is not a problem
Right now it looks like my code manages to not use configLocations() []string func.
I don't understand full logic where it should be used or should it be deleted.
Can you tip me - should I just remove this function or somewhere my code breaks core functionality?

Looks like configLocations() is unused even in master branch, so it's not related to my commits.

dominikschulz
dominikschulz requested changes Feb 26, 2025
View reviewed changes
@GLobyNew
Copy link
Contributor Author

@dominikschulz I have rebased my repo with master and commit changes to pass tests.
All tests are passed, except "make codequality": func configLocations() is unused even in master branch.

dominikschulz
dominikschulz approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dominikschulz dominikschulz merged commit 5d989aa into gopasspw:master Feb 26, 2025
8 checks passed
@GLobyNew GLobyNew deleted the mindFlagCompleter branch February 27, 2025 04:16
@AnomalRoil AnomalRoil linked an issue Mar 3, 2025 that may be closed by this pull request
bug: gopass shell completion and flags #3017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: gopass shell completion and flags
2 participants
@GLobyNew @dominikschulz