Skip to content

chore(Release): 1.0.0 #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2020
Merged

chore(Release): 1.0.0 #638

merged 3 commits into from
Feb 25, 2020

Conversation

arriolac
Copy link
Contributor

  • Adding RELEASING.md for releasing instructions
  • Forgot to update gradle-mvn-push.gradle

....once merged, the resulting commit needs to be tagged.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2020
@arriolac arriolac requested a review from barbeau February 25, 2020 22:03
Copy link
Collaborator

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment in-line.

RELEASING.md Outdated
7. Create a GitHub release with the tag

[conventional-changelog-cli]: https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-cli
[gradle-mvn-push.gradle]: https://github.com/googlemaps/android-maps-utils/blob/master/gradle-mvn-push.gradle#L65
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can similarly do:

[gradle-mvn-push.gradle]: gradle-mvn-push.gradle#L65

...here and Android Studio resolves the local file link, but doesn't seem to resolve the link to the line number. From some quick Googling I don't know if GitHub would be smart enough to resolve the line number in the shortened format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know - updating. I'm not seeing Android Studio handle markdown previews for me though. Are you using a plugin?

Copy link
Collaborator

@barbeau barbeau Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing Markdown rendering previews either right now (although I believe it did at some point? Or maybe that was IntelliJ proper...). But if I Ctrl-click (Windows) on the text in the text editor it will still take me to the file.

Here are the plugins I have installed and how my editor looks:

image

@arriolac arriolac merged commit 67f8d7d into master Feb 25, 2020
@arriolac arriolac deleted the release/1.0.0-2 branch February 25, 2020 22:18
arriolac added a commit that referenced this pull request Feb 26, 2020
* chore(Release): 1.0.0

* Linking README.

* Shorthand link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants