-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(Release): 1.0.0 #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One comment in-line.
RELEASING.md
Outdated
7. Create a GitHub release with the tag | ||
|
||
[conventional-changelog-cli]: https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-cli | ||
[gradle-mvn-push.gradle]: https://github.com/googlemaps/android-maps-utils/blob/master/gradle-mvn-push.gradle#L65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can similarly do:
[gradle-mvn-push.gradle]: gradle-mvn-push.gradle#L65
...here and Android Studio resolves the local file link, but doesn't seem to resolve the link to the line number. From some quick Googling I don't know if GitHub would be smart enough to resolve the line number in the shortened format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know - updating. I'm not seeing Android Studio handle markdown previews for me though. Are you using a plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* chore(Release): 1.0.0 * Linking README. * Shorthand link
RELEASING.md
for releasing instructionsgradle-mvn-push.gradle
....once merged, the resulting commit needs to be tagged.