fix(KmlLayer): Update constructor to take in a Context instead #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
- Coverage 19% 18.99% -0.01%
==========================================
Files 71 71
Lines 4056 4037 -19
Branches 610 607 -3
==========================================
- Hits 771 767 -4
+ Misses 3251 3238 -13
+ Partials 34 32 -2
Continue to review full report at Codecov.
|
barbeau
approved these changes
Feb 21, 2020
| @@ -128,7 +128,7 @@ public void onFeatureClick(Feature feature) { | |||
| KmlLayer kmlPolygonLayer; | |||
| try { | |||
| // KML Polyline | |||
| kmlPolylineLayer = new KmlLayer(getMap(), R.raw.south_london_line_kml, this, markerManager, polygonManager, polylineManager, groundOverlayManager); | |||
| kmlPolylineLayer = new KmlLayer(getMap(), R.raw.south_london_line_kml, this, markerManager, polygonManager, polylineManager, groundOverlayManager, null); | |||
There was a problem hiding this comment.
Suggestion - in this or KmlDemoActivity, include an example of passing in the cache
There was a problem hiding this comment.
Ah, good point. I'll update KmlDemoActivity and reuse the RetainFragment + ImagesCache strategy there
| @@ -127,29 +129,23 @@ | |||
| * Creates a new Renderer object for KML features | |||
| * | |||
| * @param map map to place objects on | |||
| * @param activity activity needed to add info windows and retain bitmap cache fragment | |||
| * @param context the Context | |||
| * @param markerManager marker manager to create marker collection from | |||
| * @param polygonManager polygon manager to create polygon collection from | |||
| * @param polylineManager polyline manager to create polyline collection from | |||
| * @param groundOverlayManager ground overlay manager to create ground overlay collection from | |||
There was a problem hiding this comment.
imagesCache should be added to Javadoc with a description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
KmlLayer,KmlRenderer, andRenderer, to accept aContextinstead of aFragmentActivity. The former signature and solution presents a couple of issues mentioned in #629.This change does break configuration change handling for caching images in a way that
retaining state across these changes is now handled by the caller (i.e. by passing in
an
ImagesCacheinstance viaKmlLayerconstructor).Fixes #629 🦕