Skip to content

docs: add instructions for authenticating for system tests #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 21, 2020

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Dec 7, 2020

Addresses this docs question: googleapis/nodejs-googleapis-common#327
We need to add authentication instructions when running system tests as well - these docs add to that.

@sofisl sofisl requested a review from a team as a code owner December 7, 2020 22:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@sofisl sofisl requested a review from bcoe December 7, 2020 22:03
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 8, 2020
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me, mind running synthtool against one repo manually first, so we can make sure it looks right?

@sofisl
Copy link
Contributor Author

sofisl commented Dec 9, 2020

Can confirm it looks right! Also added in a fix to this: #431

@bcoe bcoe removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 21, 2020
@sofisl sofisl merged commit 363fe30 into master Dec 21, 2020
@sofisl sofisl deleted the updateContributing branch December 21, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants