Skip to content

chore: add config files for cloud-rad for node.js #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jul 15, 2020

Generate and upload yaml files for ref docs.

Generate and upload yaml files for ref docs
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@fhinkel fhinkel requested review from tbpg and bcoe July 15, 2020 20:36
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a .js file, seems to be very angry about the comments in the JSON.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to be a json file, generated by api-extactor. I added a .gitattributes file instead so it looks less angry.

Copy link

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! LGTM after the JSON comment issue.

@fhinkel fhinkel force-pushed the cloud-rad branch 4 times, most recently from 69a2346 to cc11319 Compare July 16, 2020 07:45
@SurferJeffAtGoogle SurferJeffAtGoogle merged commit 21f1470 into master Jul 16, 2020
@SurferJeffAtGoogle SurferJeffAtGoogle deleted the cloud-rad branch July 16, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants