Skip to content

chore: [java] synthtool not to create an initial gitignore. #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 27, 2022

Given that new generated libraries will come to the Java monorepo going forward and that any new hand-written libraries can get a new .gitignore from humans, there's no need to automatically prepare .gitignore file.

Fixes googleapis/google-cloud-java#8683

Credit: @lqiu96 found the problematic line.

Given that new generated libraries will come to the Java monorepo
going forward and that any new hand-written libraries can get
a new .gitignore from humans, there's no need to automatically
prepare .gitignore file.
@suztomo suztomo requested a review from a team as a code owner October 27, 2022 20:16
@suztomo suztomo requested a review from lqiu96 October 27, 2022 20:16
@suztomo suztomo merged commit 0baf7e4 into googleapis:master Oct 27, 2022
@suztomo suztomo deleted the java_initial_gitignore branch October 27, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OwlBot postprocessor adds gitignore back
3 participants