Skip to content

[java templates] build.sh should detect sample-secrets #904

Closed
@chingor13

Description

@chingor13

Many libraries use secrets from secret manager for samples. We source a file in bash which loads environment variables from a secret file.

Example: https://github.com/googleapis/java-bigquerystorage/blob/031655be10038a25dcd6285166fc3269599df525/.kokoro/build.sh#L81-L84

We should generalize this (look for all -samples-secrets files) so maintainers do not need to customize build.sh and ignore the common templates.

Metadata

Metadata

Assignees

Labels

lang: javaIssues specific to Java.samplesIssues that are directly related to samples.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions