Skip to content

fix: update dependency requirements #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2021
Merged

fix: update dependency requirements #48

merged 3 commits into from
Jun 21, 2021

Conversation

dandhlee
Copy link
Collaborator

Before you open a pull request, note that this repository is forked from here.
Unless the issue you're trying to solve is unique to this specific repository,
please file an issue and/or send changes upstream to the original as well.


Missed adding sphinxcontrib.napoleon import in setup.py instead of adding it in requirements.txt. Will need to release 0.3.1 to allow docs builds to work across Client Libraries.

Fixes #47

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@dandhlee dandhlee added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jun 21, 2021
@dandhlee dandhlee requested a review from a team June 21, 2021 19:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@dandhlee dandhlee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 21, 2021
@dandhlee
Copy link
Collaborator Author

Adding a test to build without requirements.txt, making sure that the library can build successfully outside of this repo, as if users would have installed through pip.

Testing to make sure that the test works (cached settings seem to flow over, testing to see if that would affect the tests)

@dandhlee
Copy link
Collaborator Author

Tests failed as expected, reverted to original setup as intended. All is good!

@dandhlee dandhlee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 21, 2021
@dandhlee dandhlee merged commit c1c036f into master Jun 21, 2021
@dandhlee dandhlee deleted the dependency_fix branch June 21, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing import: builds not passing
2 participants