-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Selective gapic generation phase II #3730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
595198b
feat: Selective gapic generation phase II
cindy-peng f5c93db
Add selective gapic yaml files and golden files
cindy-peng 734efa9
add golden test files
cindy-peng fbb19ea
Revert service client throw comment
cindy-peng 03220b9
Revert integration golden files
cindy-peng c516814
Merge branch 'main' into cindy/selective-gapic
cindy-peng 55de64f
Merge branch 'main' into cindy/selective-gapic
cindy-peng 27bdc9e
Merge branch 'main' into cindy/selective-gapic
cindy-peng 1f77302
Remove enum from method model
cindy-peng eb0c6bf
Set default method level to be public
cindy-peng 5a21be7
Fix formatting errors
cindy-peng 5fad1fe
Change isPublic attribute to isInternalApi in method class
cindy-peng 182a517
Merge branch 'main' into cindy/selective-gapic
cindy-peng 221eb8f
Fix linter
cindy-peng ffd66db
Fix comments from PR review.
cindy-peng 602b910
Merge branch 'main' into cindy/selective-gapic
cindy-peng a87d3b0
Fix linter.
cindy-peng cbb7ce5
Add unit tests for stub, stub settings,service settings
cindy-peng 6c30173
Fix Javadoc comment line break before @InternalApi comment
cindy-peng b481cc7
Change block tag to start with lowercase to resolve formatter issue.
cindy-peng edafba1
Fix comment to be lowercase @internalApi
cindy-peng f4c9cf7
Change internalApi javadoc comment to be additional descriptive text.
cindy-peng 385873d
Merge branch 'main' into cindy/selective-gapic
cindy-peng 7c3aeaa
Add common string and unit tests for parser.
cindy-peng b0553ac
Add common string and unit tests for parser.
cindy-peng 01bc7f7
Change internal use warning message.
cindy-peng 2ece35b
Fix linter formatting.
cindy-peng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.