Skip to content

[ggj][codegen][test] feat: ServiceClientTest.rpcExceptionTest support for LRO, streaming #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 26, 2020
Merged

[ggj][codegen][test] feat: ServiceClientTest.rpcExceptionTest support for LRO, streaming #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e4f7374
fix!: refactor field into MethodArgument, add enum/msg flags
miraleung Sep 22, 2020
6489625
feat: partial isAssignableFrom VaporRef support, enable full-name typ…
miraleung Sep 23, 2020
fb565b6
feat: support negative numeric literals
miraleung Sep 24, 2020
a438128
fix: separate resname tokenizing from class composer
miraleung Sep 24, 2020
396a0cc
feat: add per-type default value composer
miraleung Sep 24, 2020
18cb9bd
feat: add ServiceClientTest.methodExceptionTests codegen
miraleung Sep 24, 2020
f45c475
feat: add rpcExceptionTest for RPCs w/o overloads, support LRO
miraleung Sep 24, 2020
f490996
fix: CI merge
miraleung Sep 24, 2020
8a87e3a
feat: ServiceClientTest.rpcExceptionTest support for LRO, streaming
miraleung Sep 25, 2020
2087c80
fix: sorted method args
miraleung Sep 25, 2020
18d2059
Merge branch 'gp/g6' into gp/g7
miraleung Sep 25, 2020
d04e9a9
Merge branch 'master' into gp/g7
miraleung Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/com/google/api/generator/engine/ast/VaporReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,14 @@ public boolean isFromPackage(String pkg) {
@Override
public boolean isSupertypeOrEquals(Reference other) {
// Not handling more complex cases for VaporReference.
return equals(other);
if (!(other instanceof VaporReference)) {
return false;
}

VaporReference ref = (VaporReference) other;
return pakkage().equals(ref.pakkage())
&& plainName().equals(ref.plainName())
&& Objects.equals(enclosingClassName(), ref.enclosingClassName());
}

@Override
Expand Down
Loading