chore: follow up fix to verify_library_generation #2721
Conversation
Co-authored-by: Joe Wang <[email protected]>
| @@ -1,6 +1,11 @@ | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
Could you merge main branch, I think this line should not change.
| echo "head_ref=${{ github.event.pull_request.head.ref }}" | ||
| echo "Head repo URL: ${{ github.event.pull_request.head.repo.html_url }} | ||
| # PRs that come from a fork need to be handled differently | ||
| if [[ ${{ github.event.pull_request.head.repo.full_name }} == ${{ github.repository }} ]]; then |
There was a problem hiding this comment.
what the difference between github.event.pull_request.head.repo.full_name and github.repository if it's a forked repo? Does the former have a different organization?
There was a problem hiding this comment.
github.repository will always be googleapis/sdk-platform-java since that's where this workflow is running from. github.event.pull_request.head.repo.fullname will have a different organization and potentially different repo name (for instance, for renovate bot, the value is: renovate-bot/gapic-generator-java)
|
Could you move github related variable to |
|
Confirmed this workflow file: https://github.com/googleapis/sdk-platform-java/actions/runs/8931135864/workflow?pr=2657 worked with #2657. Have updated this script to use that workflow file (along with some refactoring to use the env var) |
|
|
#2716 didn't quite fix what it should have. Follow up to fix the error: ``` Previous HEAD position was e54601f Merge 30c7c5b into 5d4567f Switched to a new branch 'main' branch 'main' set up to track 'origin/main'. + git fetch --no-tags --prune origin +main:refs/remotes/origin/main From https://github.com/googleapis/sdk-platform-java - [deleted] (none) -> origin/main + git checkout renovate/markupsafe-2.x error: pathspec 'renovate/markupsafe-2.x' did not match any file(s) known to git ``` --------- Co-authored-by: Joe Wang <[email protected]>
#2716 didn't quite fix what it should have. Follow up to fix the error: