Skip to content

test: validation for gapic-generator-java-bom #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 17, 2023
Merged

test: validation for gapic-generator-java-bom #1629

merged 7 commits into from
Apr 17, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Apr 14, 2023 •
edited
Loading

@suztomo suztomo requested a review from a team as a code owner April 14, 2023 19:55
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 14, 2023
@suztomo suztomo mentioned this pull request Apr 14, 2023
Merged
suztomo
suztomo commented Apr 14, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated
mvn install -B -ntp -DskipTests -Dclirr.skip -Dcheckstyle.skip
- name: Validate gapic-generator-java-bom
# Replace bom-canary-project with main once the pull request is merged
uses: googleapis/java-cloud-bom/tests/validate-bom@bom-canary-project
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo before merge: To replace this to "main".

suztomo
suztomo commented Apr 17, 2023
View reviewed changes
gapic-generator-java-bom/pom.xml Outdated
@@ -111,8 +111,13 @@
<artifactId>grpc-google-iam-v2beta</artifactId>
<version>1.11.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-iam-v2beta:current} -->
</dependency>
<dependency>
<groupId>foocom.google.api.grpc</groupId>
Copy link
Member Author

@suztomo suztomo Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This invalid entry (I added "foo" at the group ID") indeed fails the build. Good.

image

@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@suztomo suztomo merged commit eee46fe into main Apr 17, 2023
@suztomo suztomo deleted the bom_validation branch April 17, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @burkedavison