Skip to content

feat: parent pom and gapic-generator-java-bom #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 21, 2022
Merged

feat: parent pom and gapic-generator-java-bom #1170

merged 15 commits into from
Dec 21, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Dec 20, 2022 •
edited
Loading

  • gapic-generator-java-pom-parent: the parent pom of all modules.
  • gapic-generator-java-bom: the BOM for the artifacts produced by this repository.
  • modules in gax-java and api-common to have SNAPSHOT versions.

@suztomo suztomo requested a review from a team as a code owner December 20, 2022 22:20
suztomo
suztomo commented Dec 20, 2022
View reviewed changes
versions.txt
gax:2.20.1:2.20.1
gax-bom:2.20.1:2.20.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced gax-bom's occurrences with gax in Release Please annotations.

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 21, 2022
suztomo
suztomo commented Dec 21, 2022
View reviewed changes
.github/workflows/ci-maven.yaml
Comment on lines +104 to +105
run: mvn -B -ntp --projects '!.' fmt:check
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, gapic-generator-java alone does not work. So running the fmt:check plugin from the root.

@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Dec 21, 2022
@suztomo suztomo merged commit 4dd5fcf into googleapis:main Dec 21, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 21, 2022
@suztomo suztomo deleted the gapic-generator-bom branch December 21, 2022 04:11
@release-please release-please bot mentioned this pull request Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddixit14 ddixit14 ddixit14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @ddixit14