Skip to content

gax : GrpcSpannerStub create(ClientContext clientContext) not using SpannerStubSettings configuration #3360

Closed as not planned
@surbhigarg92

Description

@surbhigarg92

Regarding the bug fix for canUseDirectPath returning false when DirectPath is enabled, the recommendation was to pass clientContext in the GrpcSpannerStub.create instead of SpannerStubSetting

This approach works for standard requests, but it fails in cases where custom timeouts are applied.

Further investigation showed that passing clientContext to GrpcSpannerStub.create results in a new SpannerStubSettings.newBuilder().build() instance being created rather than using the SpannerStubSettings from clientContext . See code reference.

Using the protected constructor that accepts both stubSettings and clientContext directly resolves the issue. Refer PR

Expected fix:
Expose a new public static method for accepting both stubSettings and clientContext

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions