Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): explicitly add bq to samples reqs, upgrade grpc to fix bug on m1 #1290

Merged
merged 3 commits into from
Jul 19, 2022
Merged

docs(samples): explicitly add bq to samples reqs, upgrade grpc to fix bug on m1 #1290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3058a2b
fix: explicitly add bq to samples reqs, upgrade grpc to fix bug on m1
leahecole Jul 15, 2022
51f861d
update grpc in setup.py
leahecole Jul 18, 2022
ae318f4
fix: rm 3.6 constraints, add grpcio to 3.7-3.10 constraints
leahecole Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion samples/snippets/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
db-dtypes==1.0.1
google-cloud-bigquery==3.2.0
google-cloud-bigquery-storage==2.13.1
google-auth-oauthlib==0.5.1
grpcio==1.46.3
grpcio==1.47.0
ipython===7.31.1; python_version == '3.7'
ipython===8.0.1; python_version == '3.8'
ipython==8.3.0; python_version >= '3.9'
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# 'Development Status :: 5 - Production/Stable'
release_status = "Development Status :: 5 - Production/Stable"
dependencies = [
"grpcio >= 1.38.1, < 2.0dev", # https://github.com/googleapis/python-bigquery/issues/695
"grpcio >= 1.47.0, < 2.0dev", # https://github.com/googleapis/python-bigquery/issues/1262
# NOTE: Maintainers, please do not require google-api-core>=2.x.x
# Until this issue is closed
# https://github.com/googleapis/google-cloud-python/issues/10566
Expand Down
1 change: 1 addition & 0 deletions testing/constraints-3.10.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
grpcio==1.47.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we remove this line as we still want to test the latest version of grpcio in one of the constraints files.

Suggested change
grpcio==1.47.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had to add this explicitly to get the system tests (if not, would be happy to delete!!), but I'd suggest I make a follow up issue to clean up the versioning across different versions.

27 changes: 0 additions & 27 deletions testing/constraints-3.6.txt
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion testing/constraints-3.7.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ google-api-core==1.31.5
google-cloud-bigquery-storage==2.0.0
google-cloud-core==1.4.1
google-resumable-media==0.6.0
grpcio==1.38.1
grpcio==1.47.0
ipython==7.0.1
opentelemetry-api==1.1.0
opentelemetry-instrumentation==0.20b0
Expand Down
1 change: 1 addition & 0 deletions testing/constraints-3.8.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
grpcio==1.47.0
pandas==1.2.0
1 change: 1 addition & 0 deletions testing/constraints-3.9.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
#
# NOTE: Not comprehensive yet, will eventually be maintained semi-automatically by
# the renovate bot.
grpcio==1.47.0
pyarrow>=4.0.0