Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates test to account for UTC in failing test #501

Merged
merged 5 commits into from
Nov 10, 2022
Merged

fix: updates test to account for UTC in failing test #501

merged 5 commits into from
Nov 10, 2022

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Nov 2, 2022 •
edited
Loading

Some of the tests were not passing following the submission of #499 so this PR is being issued as part of helping to fix issue #385 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Nov 2, 2022
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2022
@chalmerlowe
Copy link
Collaborator Author

chalmerlowe commented Nov 3, 2022 •
edited
Loading

The failure in the kokoro Prerelease test is a known issue and will be corrected in a PR for the Google python-bigquery library: googleapis/python-bigquery#1376

This PR is expected to be merged into python-bigquery in release 3.3.6.

The merger of 3.3.6 occurred today. This comment is no longer relevant.

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 4, 2022
@chalmerlowe
Copy link
Collaborator Author

20221104: there is a prerelease issue with parsing the sqlalchemy version number.
The prerelease version number is x.x.0b2.
The patch value of 0b2 cannot be converted to an integer and thus the prerelease test fails.

@chalmerlowe
Copy link
Collaborator Author

@parthea can you approve and merge. See my comment above about the patch version number, which is a transient issue and should not interfere with the functionality of this PR.

@chalmerlowe chalmerlowe requested a review from parthea November 7, 2022 12:55
@chalmerlowe chalmerlowe marked this pull request as ready for review November 9, 2022 12:38
@chalmerlowe chalmerlowe requested a review from a team as a code owner November 9, 2022 12:38
@chalmerlowe chalmerlowe requested review from a team and aribray November 9, 2022 12:38
@chalmerlowe chalmerlowe mentioned this pull request Nov 9, 2022
Merged
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 10, 2022
@parthea
Copy link
Contributor

parthea commented Nov 10, 2022

Merge #499 first

@chalmerlowe chalmerlowe merged commit a050ccf into main Nov 10, 2022
@chalmerlowe chalmerlowe deleted the microsec-test-fix branch November 10, 2022 19:53
@release-please release-please bot mentioned this pull request Nov 10, 2022
Merged
atkincaid74 added a commit to KoffieLabs/python-bigquery-sqlalchemy that referenced this pull request Dec 19, 2022
@atkincaid74
REVERT MERGE
94ef139 
Revert "docs: fix changelog header to consistent size (googleapis#461)"

This reverts commit 177e70a.

Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)"

This reverts commit acc9274.

Revert "chore(main): release 1.4.4 (googleapis#462)"

This reverts commit 06c0270.

Revert "fix: require python 3.7+ (googleapis#468)"

This reverts commit 52ec808.

Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)"

This reverts commit e894dfa.

Revert "chore: add hashes to requirements.txt' (googleapis#483)"

This reverts commit cc13fe3.

Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)"

This reverts commit 484d524.

Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)"

This reverts commit 4f90d90.

Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)"

This reverts commit 4b37fed.

Revert "chore(python): exclude setup.py in renovate config (googleapis#487)"

This reverts commit 9ffc736.

Revert "chore(deps): update all dependencies (googleapis#488)"

This reverts commit 189af9b.

Revert "chore: detect samples tests in nested directories (googleapis#492)"

This reverts commit f566371.

Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)"

This reverts commit 4f72d4e.

Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)"

This reverts commit f188944.

Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)"

This reverts commit be63adc.

Revert "fix: updates test to account for UTC in failing test (googleapis#501)"

This reverts commit a050ccf.

Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)"

This reverts commit 0f6be67.

Revert "fix: use packaging version parser instead of string splitting (googleapis#513)"

This reverts commit bb7f6a7.

Revert "chore(main): release 1.5.0 (googleapis#469)"

This reverts commit 1ffab57.

Revert "chore: addressed lint issue with __version__ (googleapis#534)"

This reverts commit 4e17259.

Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)"

This reverts commit 57794c3.
atkincaid74 added a commit to KoffieLabs/python-bigquery-sqlalchemy that referenced this pull request Mar 16, 2023
@atkincaid74
REVERT MERGE
c4f5f91 
Revert "docs: fix changelog header to consistent size (googleapis#461)"

This reverts commit 177e70a.

Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)"

This reverts commit acc9274.

Revert "chore(main): release 1.4.4 (googleapis#462)"

This reverts commit 06c0270.

Revert "fix: require python 3.7+ (googleapis#468)"

This reverts commit 52ec808.

Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)"

This reverts commit e894dfa.

Revert "chore: add hashes to requirements.txt' (googleapis#483)"

This reverts commit cc13fe3.

Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)"

This reverts commit 484d524.

Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)"

This reverts commit 4f90d90.

Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)"

This reverts commit 4b37fed.

Revert "chore(python): exclude setup.py in renovate config (googleapis#487)"

This reverts commit 9ffc736.

Revert "chore(deps): update all dependencies (googleapis#488)"

This reverts commit 189af9b.

Revert "chore: detect samples tests in nested directories (googleapis#492)"

This reverts commit f566371.

Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)"

This reverts commit 4f72d4e.

Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)"

This reverts commit f188944.

Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)"

This reverts commit be63adc.

Revert "fix: updates test to account for UTC in failing test (googleapis#501)"

This reverts commit a050ccf.

Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)"

This reverts commit 0f6be67.

Revert "fix: use packaging version parser instead of string splitting (googleapis#513)"

This reverts commit bb7f6a7.

Revert "chore(main): release 1.5.0 (googleapis#469)"

This reverts commit 1ffab57.

Revert "chore: addressed lint issue with __version__ (googleapis#534)"

This reverts commit 4e17259.

Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)"

This reverts commit 57794c3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@aribray aribray Awaiting requested review from aribray

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalmerlowe @parthea @yoshi-kokoro