-
Notifications
You must be signed in to change notification settings - Fork 48
feat: support STRUCT data type with Series.struct.field
to extract child fields
#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
21b044f
feat: support STRUCT data type with `Series.struct.field` to extract …
tswast 05105a8
implement explode
tswast 3129042
fix docstrings
tswast 3c9dad0
Merge remote-tracking branch 'origin/main' into struct-accessor
tswast f4671fc
add unit tests
tswast a183708
update struct dtype tests
tswast d600a1c
cleanup before doctest
tswast 9e90b19
alternative workaround for mismatch import error
tswast e55be81
alternative workaround for mismatch import error
tswast 6c13314
remove dead ibis null to arrow check
tswast c5f6e00
Merge branch 'main' into struct-accessor
tswast 2d38534
Merge branch 'main' into struct-accessor
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from __future__ import annotations | ||
|
||
import typing | ||
|
||
import ibis.expr.types as ibis_types | ||
|
||
import bigframes.dataframe | ||
import bigframes.operations | ||
import bigframes.operations.base | ||
import bigframes.series | ||
import third_party.bigframes_vendored.pandas.core.arrays.arrow.accessors as vendoracessors | ||
|
||
|
||
class StructField(bigframes.operations.UnaryOp): | ||
def __init__(self, name_or_index: str | int): | ||
self._name_or_index = name_or_index | ||
|
||
def _as_ibis(self, x: ibis_types.Value): | ||
struct_value = typing.cast(ibis_types.StructValue, x) | ||
if isinstance(self._name_or_index, str): | ||
name = self._name_or_index | ||
else: | ||
name = struct_value.names[self._name_or_index] | ||
return struct_value[name].name(name) | ||
|
||
|
||
class StructAccessor( | ||
bigframes.operations.base.SeriesMethods, vendoracessors.StructAccessor | ||
): | ||
__doc__ = vendoracessors.StructAccessor.__doc__ | ||
|
||
def field(self, name_or_index: str | int) -> bigframes.series.Series: | ||
series = self._apply_unary_op(StructField(name_or_index)) | ||
if isinstance(name_or_index, str): | ||
name = name_or_index | ||
else: | ||
struct_field = self._dtype.pyarrow_dtype[name_or_index] | ||
name = struct_field.name | ||
return series.rename(name) | ||
|
||
def explode(self) -> bigframes.dataframe.DataFrame: | ||
import bigframes.pandas | ||
|
||
pa_type = self._dtype.pyarrow_dtype | ||
return bigframes.pandas.concat( | ||
[self.field(i) for i in range(pa_type.num_fields)], axis="columns" | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know how we might hit this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it will, honestly. Can remove for now.