Skip to content

fix: dedup special character #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 20, 2023
Merged

fix: dedup special character #209

merged 5 commits into from
Nov 20, 2023

Conversation

Genesis929
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/297590033🦕

@Genesis929 Genesis929 requested review from a team as code owners November 15, 2023 20:50
@Genesis929 Genesis929 requested a review from ashleyxuu November 15, 2023 20:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 15, 2023
@Genesis929 Genesis929 requested a review from GarrettWu November 15, 2023 21:00
ashleyxuu
ashleyxuu approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Genesis929 Genesis929 merged commit dd78acb into main Nov 20, 2023
@Genesis929 Genesis929 deleted the b297590033-dedup-issue branch November 20, 2023 18:36
@release-please release-please bot mentioned this pull request Nov 20, 2023
Merged
Genesis929 added a commit that referenced this pull request Dec 12, 2023
@Genesis929 @gcf-owl-bot
fix: dedup special character (#209)
0f19cc9 
* fix: dedup special character

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Genesis929 @GarrettWu @ashleyxuu