Skip to content

test: ignore bigframes/testing folder from testing #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented May 22, 2025

This is to disable failures like the following:

_____________ ERROR collecting bigframes/testing/polars_session.py _____________
bigframes/testing/polars_session.py:19: in
import polars
E ModuleNotFoundError: No module named 'polars'

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This is to disable failures like the following:

_____________ ERROR collecting bigframes/testing/polars_session.py _____________
bigframes/testing/polars_session.py:19: in <module>
    import polars
E   ModuleNotFoundError: No module named 'polars'
@shobsi shobsi requested review from a team as code owners May 22, 2025 21:01
@shobsi shobsi requested a review from Genesis929 May 22, 2025 21:01
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 22, 2025
@shobsi shobsi requested a review from TrevorBergeron May 22, 2025 21:01
@tswast
Copy link
Collaborator

tswast commented May 28, 2025

I mailed #1775 as an alternative. This makes sense as a quick fix, though.

@tswast tswast merged commit 393425e into main May 28, 2025
22 of 24 checks passed
@tswast tswast deleted the shobsi-ignore-polars-testing branch May 28, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants