Skip to content

feat: add __iter__, iterrows, itertuples, keys methods to DataFrame #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2023
Merged

feat: add __iter__, iterrows, itertuples, keys methods to DataFrame #164

merged 6 commits into from
Nov 3, 2023

Conversation

TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Nov 1, 2023 •
edited by tswast
Loading

BEGIN_COMMIT_OVERRIDE
feat: add DataFrame.__iter__, DataFrame.iterrows, DataFrame.itertuples, and DataFrame.keys methods (#164)

feat: add Series.__iter__ method (#164)
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners November 1, 2023 22:41
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 1, 2023
@milkshakeiii
Copy link
Contributor

Would it be in scope for this PR to add iteration for groupby as well? We have bug 303728561 in which a user wanted to iterate through a groupby.

milkshakeiii
milkshakeiii reviewed Nov 1, 2023
View reviewed changes
third_party/bigframes_vendored/pandas/core/frame.py
>>> df = bpd.DataFrame({
... 'A': [1, 2, 3],
... 'B': [4, 5, 6],
... })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this line is causing an indentation error in the doc scanner.

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit c065071 into main Nov 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the iterating branch November 3, 2023 20:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2023
@release-please release-please bot mentioned this pull request Nov 3, 2023
Merged
@tswast tswast changed the title feat: add __iter__, iterrows, itertuples, keys methods feat: add __iter__, iterrows, itertuples, keys methods to DataFrame Nov 7, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 7, 2023
@release-please
chore(main): release 0.13.0 (#165)
8b6b1c6 
🤖 I have created a release *beep* *boop*
---


## [0.13.0](https://togithub.com/googleapis/python-bigquery-dataframes/compare/v0.12.0...v0.13.0) (2023-11-07)


### Features

* `to_gbq` without a destination table writes to a temporary table ([#158](https://togithub.com/googleapis/python-bigquery-dataframes/issues/158)) ([e1817c9](https://togithub.com/googleapis/python-bigquery-dataframes/commit/e1817c9201ba4ea7fd2f8b6f4a667b010a6fec1b))
* Add `DataFrame.__iter__`, `DataFrame.iterrows`, `DataFrame.itertuples`, and `DataFrame.keys` methods ([#164](https://togithub.com/googleapis/python-bigquery-dataframes/issues/164)) ([c065071](https://togithub.com/googleapis/python-bigquery-dataframes/commit/c065071028c2f4ac80ee7f84dbeb1df385c2a512))
* Add `Series.__iter__` method ([#164](https://togithub.com/googleapis/python-bigquery-dataframes/issues/164)) ([c065071](https://togithub.com/googleapis/python-bigquery-dataframes/commit/c065071028c2f4ac80ee7f84dbeb1df385c2a512))
* Add interpolate() to series and dataframe ([#157](https://togithub.com/googleapis/python-bigquery-dataframes/issues/157)) ([b9cb55c](https://togithub.com/googleapis/python-bigquery-dataframes/commit/b9cb55c5b9354f9ff60de0aad66fe60049876055))
* Support 32k text-generation and multilingual embedding models ([#161](https://togithub.com/googleapis/python-bigquery-dataframes/issues/161)) ([5f0ea37](https://togithub.com/googleapis/python-bigquery-dataframes/commit/5f0ea37fffff792fc3fbed65e6ace846d8ef6a06))


### Bug Fixes

* Update default temp table expiration to 7 days ([#174](https://togithub.com/googleapis/python-bigquery-dataframes/issues/174)) ([4ff26cd](https://togithub.com/googleapis/python-bigquery-dataframes/commit/4ff26cdf862e9f9b91a3a1d2abfa7fbdf0af9c5b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milkshakeiii milkshakeiii milkshakeiii approved these changes

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TrevorBergeron @milkshakeiii @ashleyxuu @tswast