Skip to content

chore: vendor ibis codes and remove ibis dependency #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Dec 2, 2024

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 22, 2024
Copy link

conventional-commit-lint-gcf bot commented Nov 22, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 22, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_vendoribis branch 3 times, most recently from dde7fcc to e507865 Compare November 22, 2024 23:36
@product-auto-label product-auto-label bot added size: l Pull request size is large. size: xl Pull request size is extra large. and removed size: m Pull request size is medium. size: l Pull request size is large. labels Nov 22, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_vendoribis branch 6 times, most recently from 7ac682c to 5e412d5 Compare November 27, 2024 22:38
@chelsea-lin chelsea-lin marked this pull request as ready for review November 27, 2024 23:18
@chelsea-lin chelsea-lin requested review from a team as code owners November 27, 2024 23:18
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_vendoribis branch from 4e7d5cd to 765edd3 Compare November 28, 2024 03:59
@chelsea-lin chelsea-lin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 28, 2024
@bigframes-bot bigframes-bot removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 28, 2024
@GarrettWu GarrettWu removed their assignment Dec 2, 2024
@TrevorBergeron TrevorBergeron merged commit 421d24d into main Dec 2, 2024
23 checks passed
@TrevorBergeron TrevorBergeron deleted the main_chelsealin_vendoribis branch December 2, 2024 23:54
@tswast
Copy link
Collaborator

tswast commented Jan 3, 2025

This probably should have been labeled as deps: rather than chore: as it is user-facing and worthy of inclusion in the changelog.

From the git history, I believe this made it into bigframes 1.28.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants