Skip to content

fix: fix generic error message when entering an incorrect column name #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 6, 2024
Merged

fix: fix generic error message when entering an incorrect column name #1031

merged 7 commits into from
Oct 6, 2024

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Sep 30, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #328113227 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 30, 2024
@arwas11 arwas11 requested a review from chelsea-lin September 30, 2024 20:02
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 1, 2024
@arwas11 arwas11 requested a review from chelsea-lin October 3, 2024 19:32
@arwas11 arwas11 requested a review from chelsea-lin October 3, 2024 20:51
@chelsea-lin chelsea-lin marked this pull request as ready for review October 5, 2024 00:17
@chelsea-lin chelsea-lin requested review from a team as code owners October 5, 2024 00:17
@chelsea-lin chelsea-lin enabled auto-merge (squash) October 5, 2024 00:17
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2024
@chelsea-lin chelsea-lin merged commit 5ac217d into main Oct 6, 2024
22 of 23 checks passed
@chelsea-lin chelsea-lin deleted the b328113227-groupby-getitme-cloumn-name-error branch October 6, 2024 23:02
@release-please release-please bot mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@orrbradford orrbradford

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @chelsea-lin @orrbradford