Skip to content

feat: support STRUCT data type with Series.struct.field to extract child fields #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 3, 2023
Merged

feat: support STRUCT data type with Series.struct.field to extract child fields #71

merged 12 commits into from
Oct 3, 2023

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Sep 28, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 28, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 29, 2023
@tswast tswast marked this pull request as ready for review October 2, 2023 15:58
@tswast tswast requested review from a team as code owners October 2, 2023 15:58
@tswast tswast requested a review from TrevorBergeron October 2, 2023 15:58
@tswast tswast changed the title feat: support STRUCT data type with Series.struct.field to extract … feat: support STRUCT data type with Series.struct.field to extract child fields Oct 2, 2023
TrevorBergeron
TrevorBergeron reviewed Oct 2, 2023
View reviewed changes
bigframes/dtypes.py Outdated

if ibis_dtype in IBIS_TO_ARROW:
return IBIS_TO_ARROW[ibis_dtype]
elif isinstance(ibis_dtype, ibis_dtypes.Null):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how we might hit this case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will, honestly. Can remove for now.

tswast
tswast commented Oct 2, 2023
View reviewed changes
Copy link
Collaborator Author

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dead ibis null -> arrow check

@tswast tswast requested a review from TrevorBergeron October 2, 2023 22:08
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 17afac9 into main Oct 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the struct-accessor branch October 3, 2023 21:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@release-please release-please bot mentioned this pull request Oct 3, 2023
Merged
@mattyopl mattyopl mentioned this pull request Aug 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @TrevorBergeron