-
Notifications
You must be signed in to change notification settings - Fork 375
fix: Fixed getting project ID when running on Vertex AI; Fixes #852 #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sasha-gitg
merged 13 commits into
googleapis:main
from
Ark-kun:fix--Fixed-getitng-project-ID-when-running-on-Vertex-AI
Mar 21, 2022
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1e1cbfe
fix: Fixed getitng project ID when running on Vertex AI
Ark-kun 5b63ac3
Stopped depending on the google-api-python-client package
Ark-kun 6fe3f2a
Fixed a lint warning
Ark-kun 9b50f62
Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o…
kweinmeister 915d979
Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o…
sasha-gitg 318ad9e
Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o…
Ark-kun 46f6324
Extracted getting the project ID to another module
Ark-kun 036362e
Specified the exception type
Ark-kun 1f79bce
tests: Added project ID inference test
Ark-kun de1bb24
Added unit test
Ark-kun bfe1e98
Update test_initializer.py
Ark-kun 4f20ae0
Patched os.environ in the unit test
Ark-kun c73fc06
Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o…
kweinmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.