-
Notifications
You must be signed in to change notification settings - Fork 375
feat: Made display_name parameter optional for most calls #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gcf-merge-on-green
merged 23 commits into
googleapis:main
from
Ark-kun:feat--Made-display_name-optional-for-most-calls
Apr 5, 2022
Merged
Changes from 13 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
65224d6
feat: Made display_name optional for most calls
Ark-kun b2958ae
Reverted the change to _Dataset.create interface
Ark-kun b0e19fe
Extracted the display name generation to the _generate_display_name m…
Ark-kun 47563a0
Made Model.batch_predict(job_display_name=) optional
Ark-kun b3234dc
Removed the unused imports
Ark-kun c0d2aee
Added a unit test
Ark-kun f08c19b
Fixed getting the class name.
Ark-kun 9e5a800
Fixed code style
Ark-kun 1cfc9c1
Fixed the unit test
Ark-kun 54c658f
Merge branch 'main' into feat--Made-display_name-optional-for-most-calls
kweinmeister 701bbbd
Merge branch 'main' into feat--Made-display_name-optional-for-most-calls
kweinmeister 00977be
Restore the parameter ordering as requested by reviewer
Ark-kun 8c8c8aa
Marked the BatchPredictJob.create job_display_name parameter as optional
Ark-kun 8e69108
Merge branch 'main' into feat--Made-display_name-optional-for-most-calls
kweinmeister 560b0a8
Merge branch 'main' into feat--Made-display_name-optional-for-most-calls
kweinmeister dfd164d
Restored the parameter order in jobs.py as asked by reviewer
Ark-kun 93acea0
Added bug link to the TODO comments
Ark-kun 348b51c
Annotated _Dataset.create(display_name) as Optional
Ark-kun 57b1241
Changed docstringg as asked by the reviewer
Ark-kun fee7b89
Implemented the reviewer request: Removed the Optional[str] annotatio…
Ark-kun a695fb5
Merge branch 'main' into feat--Made-display_name-optional-for-most-calls
Ark-kun 92c1eaf
Fixed code formatting
Ark-kun 3ce47f6
Merge branch 'main' into feat--Made-display_name-optional-for-most-calls
kweinmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.