Skip to content

fix: fix aiplatform import issue #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

galz10
Copy link
Contributor

@galz10 galz10 commented Dec 15, 2022

In Colab, shapely is used by imgaug, anyone using imgaug alongside with aiplatform will run into an error AttributeError: module 'shapely.geos' has no attribute 'WKTReader' when importing aiplatform.

Adding a constraint with shapely<2.0.0 in google-cloud-aiplatform will fix this.

Fixes #1852 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Dec 15, 2022
@sasha-gitg sasha-gitg added the ready to pull Ready to be merged into the codebase. label Dec 16, 2022
@rosiezou rosiezou added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2022
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should most likely be labeled a fix and should include a more informative description.

@galz10 galz10 changed the title chore: fix aiplatform import issue fix: fix aiplatform import issue Dec 16, 2022
@galz10
Copy link
Contributor Author

galz10 commented Dec 16, 2022

This should most likely be labeled a fix and should include a more informative description.

updated description and title

@helinwang
Copy link

helinwang commented Dec 16, 2022

This is breaking quite a few Vertex notebooks in colab. Could we prioritize the fix rollout? I think we are in RRC1:Guarded not in freeze yet. Thanks!

copybara-service bot pushed a commit that referenced this pull request Dec 19, 2022
COPYBARA_INTEGRATE_REVIEW=#1860 from galz10:shaply-workaround 4005242
PiperOrigin-RevId: 496384036
@sasha-gitg sasha-gitg closed this Dec 19, 2022
@galz10 galz10 deleted the shaply-workaround branch December 19, 2022 21:03
nayaknishant pushed a commit to nayaknishant/python-aiplatform that referenced this pull request Jan 20, 2023
COPYBARA_INTEGRATE_REVIEW=googleapis#1860 from galz10:shaply-workaround 4005242
PiperOrigin-RevId: 496384036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. ready to pull Ready to be merged into the codebase. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import error with shapely.geos
6 participants