Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

refactor(samples): Fix documentation, typos, and function names #72

Merged
merged 31 commits into from
Jun 16, 2022
Merged

refactor(samples): Fix documentation, typos, and function names #72

merged 31 commits into from
Jun 16, 2022

Conversation

danielbankhead
Copy link
Contributor

Captured feedback from #67 🦕

d-goog and others added 29 commits May 26, 2022 13:55
@d-goog
feat(samples): Add POSIX samples
7ace33d
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
612b850 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@d-goog
Fix: fs.promises import
7cc13dd
@d-goog
Merge branch 'posix-samples' of https://github.com/googleapis/nodejs-…
8e4e6d1 
…storage-transfer into posix-samples
@d-goog
fix: clean-up created transfer job
e1696d1
@d-goog
chore: Add (safe) debug log
0951983
@d-goog
fix: misc bugs
4a47cd5
@d-goog
chore: remove debug log
6236e9e
@d-goog
feat: add POSIX to POSIX sample
86301e0 
- Also, update tests and comments
@d-goog
chore: typo & clean-up
1946b0c
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
7215ff6 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@d-goog
refactor: styling
cbf6aae
@d-goog
Merge branch 'posix-samples' of https://github.com/googleapis/nodejs-…
28308ed 
…storage-transfer into posix-samples
@d-goog
feat: Add POSIX Download sample
ba86cae
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
d613f20 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@d-goog
fix: Add ending '/'
9b08257
@d-goog
style: shorten variable
dc22f57
@d-goog
feat: Transfer Manifest request
bc80220
@d-goog
fix: typo
ab5dafa
@d-goog
Merge branch 'main' of https://github.com/googleapis/nodejs-storage-t…
de8d929 
…ransfer into posix-samples
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
28bb7cf 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'posix-samples' of https://github.com/googleapis/nodejs-…
12dc353 
…storage-transfer into posix-samples
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
9b199ac 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'posix-samples' of https://github.com/googleapis/nodejs-…
87c8161 
…storage-transfer into posix-samples
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
233441c 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'posix-samples' of https://github.com/googleapis/nodejs-…
56be733 
…storage-transfer into posix-samples
@d-goog
fix: replaceAll (not available in Node 12) -> replace
87c90a2
@d-goog
Merge branch 'posix-samples' of https://github.com/googleapis/nodejs-…
b7a99ca 
…storage-transfer into posix-samples
@d-goog
refactor(samples): Fix documentation, typos, and function names
72f949c
@danielbankhead danielbankhead requested a review from a team as a code owner June 15, 2022 02:02
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 15, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jun 15, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storagetransfer Issues related to the googleapis/nodejs-storage-transfer API. samples Issues that are directly related to samples. labels Jun 15, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: l Pull request size is large. labels Jun 15, 2022
@danielbankhead danielbankhead merged commit 74bc990 into main Jun 16, 2022
@danielbankhead danielbankhead deleted the posix-samples branch June 16, 2022 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Assignees
No one assigned
Labels
api: storagetransfer Issues related to the googleapis/nodejs-storage-transfer API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbankhead @JesseLovelace @d-goog