Skip to content

Validating object keys in update() #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2017
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Nov 9, 2017

This adds FieldPath validation to update( {} ) and makes sure no invalid characters are used as field paths.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2017
@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #65   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines        1478   1479    +1     
=====================================
+ Hits         1478   1479    +1
Impacted Files Coverage Δ
src/document.js 100% <100%> (ø) ⬆️
src/write-batch.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a02629...877ab5a. Read the comment docs.

@schmidt-sebastian schmidt-sebastian changed the title Remove unused variable. Validating the object keys in update() Nov 9, 2017
@schmidt-sebastian schmidt-sebastian changed the title Validating the object keys in update() Validating object keys in update() Nov 9, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 10, 2017
@schmidt-sebastian schmidt-sebastian merged commit c8b0963 into master Nov 10, 2017
This was referenced Nov 16, 2017
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-unused branch January 30, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants