Skip to content

Adding getCollections() to Typescript typings. #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2017

Conversation

schmidt-sebastian
Copy link
Contributor

This also makes 'ntsc -p .' work with test/typescript.d.ts by removing the source dependency on *.js (as it duplicates the namespace)

Fixes: #52

This allos makes 'ntsc -p .' work with test/typescript.d.ts by removing the source dependency on *.js (as it duplicates the namespace)
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2017
@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #62   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines        1478   1478           
=====================================
  Hits         1478   1478
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️
src/reference.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bd670...e2cb6eb. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@c9bd670). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #62   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     11           
  Lines             ?   1478           
  Branches          ?      0           
=======================================
  Hits              ?   1478           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø)
src/reference.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bd670...e2cb6eb. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit 3435258 into master Nov 8, 2017
This was referenced Nov 16, 2017
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-typings branch January 30, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants