Support empty GeoPoint #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 1864 1864
Branches 378 378
=====================================
Hits 1864 1864Continue to review full report at Codecov.
|
gsoltis
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes firebase/firebase-admin-node#337
Note that the original issue doesn't reproduce for me, but the 'latitude' and 'longitude' itself is defined as optional and can therefore be omitted. We would have caught this with stricter types (as added in this PR).