Skip to content

Drop Node 4/9 support and Lint pre-submit #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2018
Merged

Drop Node 4/9 support and Lint pre-submit #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9dc30
Drop Node 4/9 support and Lint pre-submit
schmidt-sebastian Jul 3, 2018
f3990e1
Merge branch 'master' into dropnode4
schmidt-sebastian Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 6 additions & 42 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,22 @@ workflows:
version: 2
tests:
jobs: &workflow_jobs
- node4:
- node6:
filters: &all_commits
tags:
only: /.*/
- node6:
filters: *all_commits
- node8:
filters: *all_commits
- node9:
filters: *all_commits
- node10:
filters: *all_commits
- lint:
requires:
- node4
- node6
- node8
- node9
- node10
filters: *all_commits
- docs:
requires:
- node4
- node6
- node8
- node9
- node10
filters: *all_commits
- system_tests:
requires:
- lint
- docs
filters:
branches:
Expand All @@ -56,9 +41,9 @@ workflows:
only: master
jobs: *workflow_jobs
jobs:
node4:
node6:
docker:
- image: 'node:4'
- image: 'node:6'
user: node
steps: &unit_tests_steps
- checkout
Expand Down Expand Up @@ -87,40 +72,19 @@ jobs:
name: Submit coverage data to codecov.
command: node_modules/.bin/codecov
when: always
node6:
docker:
- image: 'node:6'
user: node
steps: *unit_tests_steps
node8:
docker:
- image: 'node:8'
user: node
steps: *unit_tests_steps
node9:
docker:
- image: 'node:9'
user: node
steps: *unit_tests_steps
node10:
docker:
- image: 'node:10'
user: node
steps: *unit_tests_steps
lint:
docker:
- image: 'node:8'
user: node
steps:
- checkout
- run: *remove_package_lock
- run: *npm_install_and_link
- run:
name: Run linting.
command: npm run lint
docs:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand All @@ -131,7 +95,7 @@ jobs:
command: npm run docs
system_tests:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand All @@ -157,7 +121,7 @@ jobs:
when: always
publish_npm:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=4.0.0"
"node": ">=6.0.0"
},
"repository": "googleapis/nodejs-firestore",
"main": "./build/src/index.js",
Expand Down