Skip to content

fix: Aggregate query readtime bug #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2025
Merged

fix: Aggregate query readtime bug #2331

merged 2 commits into from
Apr 19, 2025

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Apr 17, 2025 •
edited
Loading

Fixes #2330

@tom-andersen tom-andersen requested review from a team as code owners April 17, 2025 18:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Apr 17, 2025
@tom-andersen tom-andersen changed the title Fix timestamp bug fix: Aggregate query readtime bug Apr 17, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2025
MarkDuckworth
MarkDuckworth approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the thought on test improvement

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2025
@tom-andersen tom-andersen merged commit 9ac0394 into main Apr 19, 2025
17 checks passed
@tom-andersen tom-andersen deleted the tomandersen/b2330 branch April 19, 2025 22:14
@release-please release-please bot mentioned this pull request Apr 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

‎AggregateQuery looses nanoseconds in readTime
3 participants
@tom-andersen @MarkDuckworth @yoshi-kokoro