Fix: Use lazy encoding for utf-8 encoded string comparison #2299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
milaGGL
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
dconeybe
reviewed
Feb 19, 2025
dconeybe
reviewed
Feb 19, 2025
product-auto-label
bot
added
size: l
milaGGL
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
milaGGL
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ehsannas
approved these changes
Feb 26, 2025
| } | ||
| } | ||
|
|
||
| class Random { |
There was a problem hiding this comment.
why not use Math.random()?
| } | ||
| } | ||
|
|
||
| describe('CompareUtf8Strings', () => { |
There was a problem hiding this comment.
Nit: You can move the StringPair, StringPairGenerator, StringBuilder, etc classes into this describe scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix created a performance issue due to expensive UTF-8 encoding. Update
compareUtf8Stringsto use lazy encoding instead.