Using the protos from google-proto-files #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1802 1802
=====================================
Hits 1802 1802Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
fixprotos
branch
from
16c17c6 to
d765d8f
Compare
stephenplusplus
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
This PR removes our local copy of the Firestore protos and instead relies on the
google-proto-filesdependency, which also defines all of our proto dependencies such asgoogle/api/annotations.proto.