Improved error messages for custom types #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1729 1731 +2
=====================================
+ Hits 1729 1731 +2
Continue to review full report at Codecov.
|
mikelehen
suggested changes
Mar 21, 2018
src/validate.js
Outdated
| default: | ||
| return new Error( | ||
| "Firestore doesn't support serialization of JavaScript objects " + | ||
| "that were constructed using the 'new' operator." |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| assert.throws(() => { | ||
| firestore | ||
| .doc('collectionId/documentId') | ||
| .set({foo: Firestore.FieldPath.documentId()}); | ||
| }, /Cannot use "FieldPath" as a Firestore type./); | ||
| }, /Cannot use object of type "FieldPath" as a Firestore value./); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #143
This PR changes two of our error messages:
There might be much better ways to express this, and the easiest way to figure out if the changes here make sense is to look at the test cases that show these error messages.
Note that the code tested in
order.jsis not reachable from customer code. The tests exists to allow for 100% coverage (touches linenodejs-firestore/src/order.js
Line 82 in 463fbfc