Adding isEqual to the public API #140
Conversation
ghost
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1688 1728 +40
=====================================
+ Hits 1688 1728 +40
Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
equals
branch
from
6428b23 to
428f8dc
Compare
schmidt-sebastian
force-pushed
the
equals
branch
from
b5fd2be to
0b038c9
Compare
src/document.js
Outdated
| this === other || | ||
| (is.instance(other, DocumentSnapshot) && | ||
| this._ref.isEqual(other._ref) && | ||
| deepEqual(this._fieldsProto, other._fieldsProto)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/path.js
Outdated
| isEqual(other) { | ||
| return ( | ||
| this === other || | ||
| (is.instanceof(other, Path) && this.compareTo(other) === 0) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -106,6 +106,20 @@ class WriteResult { | |||
| get writeTime() { | |||
| return this._writeTime; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns true if this `WriteResult` is equal to the provided value. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/collection.js
Outdated
| @@ -142,4 +142,12 @@ describe('Collection interface', function() { | |||
| assert.ok(documentRef.id.length, 20); | |||
| }); | |||
| }); | |||
|
|
|||
| it('has equals() method', function() { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
schmidt-sebastian
force-pushed
the
equals
branch
from
f02041d to
a609421
Compare
ghost
removed
the
cla: yes
This adds isEquals to all out public API types, ignoring metadata for all *Snapshots.
The API is mostly a port from Web, with the addition of an isEqulas for WriteResult and DocumentChange.
There are also some changes to QueryDocumentSnapshot to make equals more efficient when not all changes are materialized yet.