Skip to content

100% Test coverage and misc cleanup #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2018
Merged

100% Test coverage and misc cleanup #139

merged 2 commits into from
Feb 17, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 17, 2018

This PR brings us back to 100% test coverage (which dropped to an all time low of 99% with #137) and cleans up some test RegExp syntax since we don't enfore line length anymore in tests.

This also moves the Field Path tests to one consolidated place.

Note: The 100% coverage change is

- .update('foo', 'bar', {exists: true}, 'foo');  
+ .update('foo', 'bar', {exists: true});

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2018
@codecov
Copy link

codecov bot commented Feb 17, 2018

Codecov Report

Merging #139 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #139      +/-   ##
========================================
+ Coverage   99.94%   100%   +0.05%     
========================================
  Files          12     12              
  Lines        1689   1688       -1     
========================================
  Hits         1688   1688              
+ Misses          1      0       -1
Impacted Files Coverage Δ
src/write-batch.js 100% <ø> (ø) ⬆️
src/reference.js 100% <ø> (ø) ⬆️
src/document.js 100% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463fbfc...76c8cd9. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit 35c1af0 into master Feb 17, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2018
@schmidt-sebastian schmidt-sebastian deleted the testcoverage branch June 26, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants