This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Fix samples readme reference #423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
This file is auto generated from the template here. I was thinking of this as being the README file that the samples have, vs., the README file at the top level, so I'm also not 100% that it's worth the trouble of dropping the possessive (as it would require updating 80+ README documents). It might be worth just opening an issue, and when we make a larger edit to the README we coudl pull this in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
samplesis plural, it's actually the "samples directory" directory which would be singular (and thus if you're going to use an apostrophe, it'd besamples's. But in normal speech, we talk about files in a directory just as such... It's simpler to omit the possessive.Beyond that, markdown can link to files, which makes things better.
Note: if you actually mean "each sample's readme" then it would be best to use the word each, as otherwise the most likely interpretation is the one I'm making, or at the very least it's definitely ambiguous.