Skip to content

fix: make an explicit dependency on long #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2019
Merged

fix: make an explicit dependency on long #352

merged 1 commit into from
Mar 6, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Mar 6, 2019

I learned something today! The -i flag on pbts will let you specific which imports to explicitly bring in. Not sure why I need to do this, but πŸ€·β€β™‚οΈ Fixes #345.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2019
@JustinBeckwith JustinBeckwith merged commit 14cfe99 into googleapis:master Mar 6, 2019
@callmehiphop
Copy link
Contributor

callmehiphop commented Mar 6, 2019

Oh man, I've failed you @JustinBeckwith looks like this imports long and the global reference is Long. I just noticed when making the same change in pubsub 😭

@JustinBeckwith
Copy link
Contributor Author

This was like... not an obvious fix.

@JustinBeckwith
Copy link
Contributor Author

Does this mean I didn't fix it?

@callmehiphop
Copy link
Contributor

Yeah, I think so, lol.

@SimenB
Copy link
Contributor

SimenB commented Mar 8, 2019

I opened up #358. I think that's it πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants