Skip to content

refactor(ts): enable noImplicitAny on test/transaction.ts #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 7, 2019
Merged

refactor(ts): enable noImplicitAny on test/transaction.ts #344

merged 16 commits into from
Mar 7, 2019

Conversation

josecervino
Copy link

Fixes #326

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2019
JustinBeckwith
JustinBeckwith suggested changes Mar 1, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 4, 2019 •
edited
Loading

Codecov Report

Merging #344 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files           7        7           
  Lines         583      583           
  Branches       63       63           
=======================================
  Hits          569      569           
  Misses          6        6           
  Partials        8        8
Impacted Files Coverage Δ
src/request.ts 99.37% <ø> (ø) ⬆️
src/transaction.ts 96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab2f9d...0a14425. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

@joecervino looking better! Can you npm run fix to get CI happy? Then I'll take a look.

JustinBeckwith
JustinBeckwith suggested changes Mar 4, 2019
View reviewed changes
@josecervino
Copy link
Author

@JustinBeckwith just a friendly ping, changes made!

JustinBeckwith
JustinBeckwith suggested changes Mar 5, 2019
View reviewed changes
@JustinBeckwith
Copy link
Contributor

Please run npm run fix

@josecervino
Copy link
Author

@JustinBeckwith done :)

Thanks btw, I appreciate you taking the time to get through this

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2019
@JustinBeckwith JustinBeckwith merged commit da8e323 into googleapis:master Mar 7, 2019
@josecervino josecervino deleted the test/transaction.ts branch March 7, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josecervino @JustinBeckwith @googlebot