Skip to content

Add a function to complain about obselete packages. #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2017
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions core/google/cloud/obselete.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import pkg_resources
import warnings


def complain(distribution_name):
"""Issue a warning if `distribution_name` is installed.

In a future release, this method will be updated to raise ImportError
rather than just send a warning.

Args:
distribution_name (str): The name of the obselete distribution.
"""
try:
pkg_resources.get_distribution(distribution_name)
warnings.warn(
'The {pkg} distribution is now obselete. '
'Please `pip uninstall {pkg}`. '
'In the future, this warning will become an ImportError.'.format(
pkg=distribution_name,
),
DeprecationWarning,
)
except pkg_resources.DistributionNotFound:
pass
31 changes: 31 additions & 0 deletions core/tests/unit/test_obselete.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import warnings

import mock

from google.cloud import obselete


def test_complain_noop():
with mock.patch.object(warnings, 'warn', autospec=True) as warn:
obselete.complain('bogus_package')
assert warn.call_count == 0


def test_complain():
with mock.patch.object(warnings, 'warn', autospec=True) as warn:
obselete.complain('google-cloud-core')
warn.assert_called_once_with(mock.ANY, DeprecationWarning)